Consolidate SAMPLED and COLD page heap partitions. - #714
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Consolidate SAMPLED and COLD page heap partitions.#714copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_979226826
branch
2 times, most recently
from
September 10, 2026 18:46
5197902 to
fe58b1f
Compare
copybara-service
Bot
changed the title
Consolidates the SAMPLED and COLD page heap partitions into a single COLD partition, reducing kNumHeaps from 3 to 2. Both partitions use MADV_NOHUGEPAGE. - PageAllocator: Route sampled memory tags to cold_impl_, allocate cold_impl_ unconditionally, and remove sampled_impl_ and has_cold_impl_. - tcmalloc.cc: Update do_free_with_size and handle_sampled_or_illformed_ptrs to properly route and handle sampled allocations in cold_impl_. - central_freelist.cc: Assert !free_span->sampled() on deallocation. - Update tests to account for sampled allocations carrying MemoryTag::kCold. PiperOrigin-RevId: 979226826
copybara-service
Bot
force-pushed
the
test_979226826
branch
from
September 11, 2026 00:42
fe58b1f to
d0dde7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate SAMPLED and COLD page heap partitions.
Consolidates the SAMPLED and COLD page heap partitions into a single COLD
partition, reducing kNumHeaps from 3 to 2.
Both partitions use MADV_NOHUGEPAGE.
unconditionally, and remove sampled_impl_ and has_cold_impl_.
properly route and handle sampled allocations in cold_impl_.